❮

[Commitfest 2022-07] is Done!

  • Jump to comment-1
    jchampion@timescale.com2022-08-01T15:40:18+00:00
    Hi all, I've just closed out the July commitfest. I'll be working to clear out all remaining active patches today. Final statistics: Needs review: 142 Waiting on Author: 44 Ready for Committer: 19 Committed: 76 Moved to next CF: 6 Returned with Feedback: 7 Rejected: 3 Withdrawn: 11 -- Total: 308 Over the course of the month, 55 additional entries were committed; since March, that's 76 entries committed from 64 authors. There were of course many more threads that made progress thanks to reviewers' contributions and authors' efforts -- it's just harder for me to track those numbers. Thanks to all for your contributions and reviews! --Jacob
    • Jump to comment-1
      jchampion@timescale.com2022-08-01T23:08:35+00:00
      On 8/1/22 08:40, Jacob Champion wrote: > I've just closed out the July commitfest. I'll be working to clear out > all remaining active patches today. "Today" was slightly optimistic. I'm down to the final stretch of forty patches; I'll come back to those tomorrow with fresh eyes. --Jacob
      • Jump to comment-1
        jchampion@timescale.com2022-08-02T22:31:14+00:00
        On 8/1/22 16:08, Jacob Champion wrote: > "Today" was slightly optimistic. I'm down to the final stretch of forty > patches; I'll come back to those tomorrow with fresh eyes. All right, every entry from July has been closed out or moved! Apologies for dropping entries from cfbot temporarily; that should all be fixed now (and I've made a note in the wiki for the next CFM). We closed roughly 40% of the July entries, and decreased the volume of entries in the next CF by almost a hundred, which I think we should all feel pretty good about. (Hopefully many of the Returned patches will come back refreshed, but also hopefully that will be balanced out by commits from the RfC queue.) Thanks for having me as CFM! --Jacob
        • Jump to comment-1
          pryzby@telsasoft.com2022-08-02T22:53:25+00:00
          On Tue, Aug 02, 2022 at 03:31:14PM -0700, Jacob Champion wrote: > Apologies for dropping entries from cfbot temporarily; that should all be > fixed now (and I've made a note in the wiki for the next CFM). Actually, I think that might happen every CF, no matter what you do. cfbot indexes on (commitfest_id, submission_id). It's a known deficiency, and I was thinking of sending a partial patch the next time I look at it. -- Justin
    • Jump to comment-1
      tgl@sss.pgh.pa.us2022-08-01T16:44:14+00:00
      Jacob Champion <jchampion@timescale.com> writes: > I've just closed out the July commitfest. I'll be working to clear out > all remaining active patches today. Thanks for all your hard work on this! An active CFM really makes things work better. regards, tom lane
      • Jump to comment-1
        alvherre@alvh.no-ip.org2022-08-01T17:33:51+00:00
        On 2022-Aug-01, Tom Lane wrote: > Jacob Champion <jchampion@timescale.com> writes: > > I've just closed out the July commitfest. I'll be working to clear out > > all remaining active patches today. > > Thanks for all your hard work on this! An active CFM really makes > things work better. Agreed, great work here. I hate to suggest even more work, but it would be excellent to have some sort of write-up of what you did here, and have it supplant the obsolete text currently in the canonical commifest wiki page, https://wiki.postgresql.org/wiki/CommitFest_Checklist -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
        • Jump to comment-1
          jchampion@timescale.com2022-08-01T23:03:11+00:00
          On Mon, Aug 1, 2022 at 10:34 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > On 2022-Aug-01, Tom Lane wrote: > > Thanks for all your hard work on this! An active CFM really makes > > things work better. > > Agreed, great work here. Thanks, both of you! > I hate to suggest even more work, but it would be excellent to have some > sort of write-up of what you did here, and have it supplant the obsolete > text currently in the canonical commifest wiki page, > https://wiki.postgresql.org/wiki/CommitFest_Checklist Sure, I think I can do that. I'll be writing up my experiences for Timescale later this month. So maybe I could remove (or else clearly mark) the things that are personal opinions only, keep the more procedural notes, and use that as the base for a rework of the wiki? --Jacob
          • Jump to comment-1
            alvherre@alvh.no-ip.org2022-08-02T06:44:04+00:00
            On 2022-Aug-01, Jacob Champion wrote: > On Mon, Aug 1, 2022 at 10:34 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > I hate to suggest even more work, but it would be excellent to have some > > sort of write-up of what you did here, and have it supplant the obsolete > > text currently in the canonical commifest wiki page, > > https://wiki.postgresql.org/wiki/CommitFest_Checklist > > Sure, I think I can do that. I'll be writing up my experiences for > Timescale later this month. So maybe I could remove (or else clearly > mark) the things that are personal opinions only, keep the more > procedural notes, and use that as the base for a rework of the wiki? I don't think there's anything in that page that I would keep. If you did read this page and follow some part of it while running this CF, by all means keep that; but otherwise I think it may be better to start afresh. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Nunca se desea ardientemente lo que solo se desea por razón" (F. Alexandre)
            • Jump to comment-1
              rjuju123@gmail.com2022-08-03T01:30:11+00:00
              On Tue, Aug 02, 2022 at 08:44:04AM +0200, Alvaro Herrera wrote: > On 2022-Aug-01, Jacob Champion wrote: > > > On Mon, Aug 1, 2022 at 10:34 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > > > I hate to suggest even more work, but it would be excellent to have some > > > sort of write-up of what you did here, and have it supplant the obsolete > > > text currently in the canonical commifest wiki page, > > > https://wiki.postgresql.org/wiki/CommitFest_Checklist > > > > Sure, I think I can do that. I'll be writing up my experiences for > > Timescale later this month. So maybe I could remove (or else clearly > > mark) the things that are personal opinions only, keep the more > > procedural notes, and use that as the base for a rework of the wiki? > > I don't think there's anything in that page that I would keep. If you > did read this page and follow some part of it while running this CF, by > all means keep that; but otherwise I think it may be better to start > afresh. +1, I had the same feeling last time (1). [1] https://www.postgresql.org/message-id/20220202175656.5zacgx3ucrquvi35@jrouhaud